Test case for minified aliases failing to resolve identifiers correctly. #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive test case to verify that minified aliases work correctly with complex nested includes in Sequelize 7. The test creates a multi-table scenario with many-to-many and one-to-many relationships to ensure identifier resolution functions properly when minifyAliases is enabled.
Key changes:
- Replaces simple test with complex multi-model test scenario
- Enables
minifyAliasesconfiguration option to test alias resolution - Creates realistic business domain models (Location, Customer, System, FuelDelivery) with proper associations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/sscce-sequelize-7.ts | Complete rewrite with multi-model test case for minified alias resolution |
| dev/create-sequelize-instance.ts | Adds generic type parameter to fix TypeScript compatibility |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.